Open
Conversation
…view of dashborad on a header along with PR and author'
Task: Implement SHA Display in PreSubmitView Header Summary: Updated the title construction logic in PreSubmitView to include the first 7 characters of the commit SHA. The header now follows the format 'PR flutter#123 by author (sha)' when loaded, 'PR flutter#123' when loading via PR, and '(sha)' when loading via SHA. Files: dashboard/lib/views/presubmit_view.dart, dashboard/test/views/presubmit_view_test.dart Why: Improves visibility of the specific commit being inspected in the CI results view.
…w of dashborad on a header along with PR and author' as complete
…n presubmit view of dashborad on a header along with PR and author'
…view of dashborad on a header along with PR and author'
jtmcdole
requested changes
Feb 18, 2026
| ]; | ||
| } | ||
|
|
||
| final shortSha = (sha != null && sha!.length > 7) |
Member
There was a problem hiding this comment.
This is not doing what you think it does - the substring is saying "Take the last 7 characters of the sha" not "take the first 7 characters". Here's a better way:
final shortSha = (sha == null) ? 'missing' : (sha.length > 7 ? sha.substring(0, 7) : sha);| createPreSubmitView({'repo': 'flutter', 'sha': 'abcdef123456'}), | ||
| ); | ||
| // No pump() here to stay in loading state | ||
| expect(find.text('(f123456)'), findsOneWidget); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add short sha to presubmit view header
Fix: flutter/flutter#176983