Add --add-ignore-paths flag to artifact commands#5885
Open
stratch1989 wants to merge 1 commit into
Open
Conversation
The existing --ignore-paths flag replaces the built-in default exclude list (VCS files and common ignored extensions), which forces users to re-specify every default when they only need to add one extra pattern. This change introduces --add-ignore-paths for push/build/diff artifact, which appends its values to whichever ignore set is currently in effect (defaults when --ignore-paths is omitted, or the user override when it is provided). --ignore-paths semantics are unchanged. Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com> Assisted-by: claude-code/claude-opus-4-7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5144
What
Adds
--add-ignore-pathstoflux build artifact,flux push artifact,and
flux diff artifact. It appends user-provided patterns to whateverignore set is currently in effect, instead of forcing a full replacement
like
--ignore-pathsdoes.How it composes
--ignore-paths X→ X (replace, existing behaviour, unchanged)--add-ignore-paths Y→ defaults + YTests
Unit tests for
composeIgnorePathscovering empty input, ignore-pathsonly, add-ignore-paths only, both flags combined, duplicates retained,
and the defaults+add common case.
Local testing notes
On Apple Silicon the Makefile's
setup-envtest use latest --arch=amd64step fails (
bad CPU type in executable). I ran envtest manually with--arch=arm64and pointedKUBEBUILDER_ASSETSat the arm64 dir; thefull
cmd/flux/...test suite passes. CI on linux/amd64 should beunaffected.