Turn libfmt-c into shared#4812
Conversation
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
Please don't add new headers.
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
I think it's OK to have a separate macro for now, but let's rename it from CFMT_API to FMT_CAPI to avoid reserving a new prefix. And similarly for visibitlity.
jengelh
force-pushed
the
master
branch
2 times, most recently
from
fb105dc to
da0bacb
Compare
|
We're looking to distribute 12.2.0 in the freedesktop-sdk project and also agree that we would prefer not to include the static lib: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/merge_requests/32873 |
Updates elements/components/fmtlib.bst to 12.2.0-0 (1be298e) Previous version was 12.1.0-0 (407c905) Fix for i686 32bit compilation landed after release: fmtlib/fmt@588b3a0f8f6a8bcf2a959cae882d5 b2703e86737 Static libfmt-c archive introduced via: fmtlib/fmt@dc97113ca160beea3ac33a781bac5 2829456ff60 Subsequently patched to be shared after the release via: fmtlib/fmt#4812
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
There are some CI failures.
I do not know how to fix this. On a whim I had previously tried switching |
Linux distros don't like having static archives. Set fmt-c to shared just like the main fmt library.
|
Thanks for this! |
3 participants
Linux distros don't like having static archives. Set fmt-c to shared just like fmt.