Skip to content

ci: avoid reusing stale apt cache #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tueda wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −12
Open

ci: avoid reusing stale apt cache #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8c0ae
test(check.rb): rerun FORM to show errors if the first run fails
tueda Feb 13, 2026
e1b5bfc
ci: include runner image version in cache key for cache-apt-pkgs-action
tueda Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions .github/actions/setup-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,11 @@ runs:
echo "DISTNAME=form-$(./scripts/git-version-gen.sh -r | sed '2q;d' | sed 's/^v//')" >>"$GITHUB_ENV"
fi

# Get cache key for the image ###

# See: https://github.com/actions/upload-artifact/issues/231
echo "image_key=$ImageOS-$ImageVersion" >>"$GITHUB_OUTPUT"

- name: Install dependencies (Ubuntu)
if: runner.os == 'Linux' && steps.setup.outputs.container == 'false'
uses: awalsh128/cache-apt-pkgs-action@a605dbde2ac49a823c9c87ad58491b51848bf355 # for empty_packages_behavior
Expand All @@ -281,7 +286,9 @@ runs:
${{ steps.setup.outputs.mpfr == 'true' && 'libmpfr-dev' || '' }}
${{ steps.setup.outputs.zstd == 'true' && 'libzstd-dev' || '' }}
${{ steps.setup.outputs.valgrind == 'true' && 'valgrind' || '' }}
version: 1.0
# Include the runner image version in the cache key to avoid using stale cache.
# See: https://github.com/awalsh128/cache-apt-pkgs-action/issues/187
version: ${{ steps.setup.outputs.image_key }}-1.0
empty_packages_behavior: ignore

# awalsh128/cache-apt-pkgs-action does not work for MPI.
Expand Down Expand Up @@ -440,16 +447,6 @@ runs:
${{ steps.setup.outputs.zlib == 'true' && 'mingw-w64-clang-aarch64-zlib' || '' }}
${{ steps.setup.outputs.zstd == 'true' && 'mingw-w64-clang-aarch64-zstd' || '' }}

- name: Get cache key for the image
id: cache_key
if: steps.setup.outputs.build_flint == 'true'
shell: ${{ steps.setup.outputs.msys2 == 'true' && 'msys2 {0}' || 'bash' }}
run: |
### Get cache key for the image ###

# See: https://github.com/actions/upload-artifact/issues/231
echo "image_key=$ImageOS-$ImageVersion" >>"$GITHUB_OUTPUT"

- name: Cache FLINT
id: cache-flint
if: steps.setup.outputs.build_flint == 'true'
Expand All @@ -458,7 +455,7 @@ runs:
path: lib/flint
# Here, we set a conservative cache key so that the cache is not reused
# when the version or environment changes even slightly.
key: flint-${{ inputs.flint_version }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.cache_key.outputs.image_key }}
key: flint-${{ inputs.flint_version }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.setup.outputs.image_key }}

# Note that we always set --enable-static so that release and non-release
# builds can share the same cache.
Expand Down
1 change: 1 addition & 0 deletions check/check.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,7 @@ def check
@head = form_version_line
end
else
system("#{@form_cmd} #{frmname}")
fatal("failed to execute '#{@form_cmd}'")
end
if !@valgrind.nil?
Expand Down
Loading