Conversation
|
I believe all AVX dependencies are now completely splitted by
|
|
This looks great, thanks! I have a question: do you know if compiling the dependencies with |
| printf("Run tests for Gimli.\n"); | ||
| printf("\nRun tests for Gimli.\n"); | ||
| printf("Usage: %s TESTYPE\n", name); | ||
| #ifdef AVX_SUPPORT |
There was a problem hiding this comment.
I would just wrap the whole thing inside the ifdef and not mention TESTTYPE at all if there is only one option. i.e., when AVX2 is disabled. Do you think this is a good idea? Also, it would be nice to add a sentence that says "run all the tests for gimli" or something similar.
[Issue #16]
I've parameterize the AVX support using
#ifdef AVX_SUPPORT. But I need some help updating the Makefile in order to avoid compiling the Jasmin AVX filesTo enable AVX support, the C program has to be compiled using
-DAVX_SUPPORT(we can also change the name)