fix(compose): suppress non-error logs when loading compose project #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detsch
reviewed
Jan 23, 2026
Member
detsch
left a comment
detsch
left a comment
There was a problem hiding this comment.
Typo in commit message: "jsut"
LGTM.
detsch
approved these changes
Jan 23, 2026
The "LoadWithContext" API call of the "compose-go" project may produce warning logs while loading a compose project. This causes issue when a CLI command outputs result in json format. Hence, this change suppressing all non-error logs yielded by "LoadWithContext" by setting the "error" level for the "logrus" just before making the load call. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
suppress-compose-go-logs
branch
from
bb59aa2 to
affc452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "LoadWithContext" API call of the "compose-go" project may produce warning logs while loading a compose project. This causes issue when a CLI command outputs result in json format. Hence, this change suppressing all non-error logs yielded by "LoadWithContext" by setting the "error" level for the logrus jsut before making the load call.