-
Notifications
You must be signed in to change notification settings - Fork 4
Improve SQLite3 primary key constraint parsing #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SQLite3 primary key constraint parsing #24
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 3881 3880 -1
=====================================
+ Misses 3881 3880 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stellar docstrings on this code 😄 took me a little bit to understand exactly what this was handling. I don't expect you to document all this old code but at least adding a comment on what your change handles would be very much appreciated.
I know the unit test also shows it, but showing it briefly in the code makes the code much easier to reason about.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Schamper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the linter?
This PR fixes SQLite3 table parsing for tables with primary keys defined in a table constraint. Specifically, constraints with multiple parts (but whom are not compound/composite or an expression). See the added test for an example.