-
Notifications
You must be signed in to change notification settings - Fork 4
Fix SQLite3 Cell data overflow reading for databases with header.reserved_size set
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQLite3 Cell data overflow reading for databases with header.reserved_size set
#25
Conversation
|
You know the question that's coming: is it possible to have some test data for this edge case? Also @PimSanders since you've been looking into SQLite for a little while now, what are your thoughts on this? |
The PR for #17 will include test data that covers this change. |
|
Added a separate test for this case in 3a09e78. |
|
I think I understand where this issue comes from and how the fix works. Seems to me like a good fix for the issue. Only thing I noticed is that Haven't been able to test it yet, so correct me if I'm wrong. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 3880 3879 -1
=====================================
+ Misses 3880 3879 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Schamper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL ruff lints Python inside docstrings.
This PR fixes
Cell.datareading for databases when parsing a cell value larger than the (usable) page size. Currently the overflow page lookup implementation does not calculate thedata_sizecorrectly for databases withheader.reserved_sizeset.