-
Notifications
You must be signed in to change notification settings - Fork 4
Add SQLCipher CE implementation #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| DEFAULT_HMAC_ALGO = None | ||
|
|
||
|
|
||
| class SQLCipherPage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is now largely unnecessary and can be replaced by either inlining it in _read_page or splitting it up in one or two functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you propose? Some form of a class structure per page could still be useful for future debugging purposes. I agree that the current form of the class is overkill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Erik Schamper <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 146 150 +4
Lines 3893 4052 +159
======================================
- Misses 3893 4052 +159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR implements transparent decryption support for SQLCipher community edition versions 1 up to 4. Fixes #17.