Skip to content

Conversation

@Schamper
Copy link
Member

Needed a few more utilities. Also started returning [] for multi-valued attributes that don't have any value, instead of None. This saves checking for or [] in a few places.

@Schamper Schamper requested a review from joost-j February 10, 2026 13:06
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (c85667a) to head (fa372c7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/database/ese/ntds/util.py 0.00% 13 Missing ⚠️
dissect/database/ese/ntds/objects/object.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #29   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        146     146           
  Lines       3893    3908   +15     
=====================================
- Misses      3893    3908   +15     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing moaaarr-ntds (fa372c7) with main (c85667a)

Open in CodSpeed

@Schamper Schamper merged commit 6149d6f into main Feb 10, 2026
24 checks passed
@Schamper Schamper deleted the moaaarr-ntds branch February 10, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants