fix: validate DNN static IP before subscriber writes - #223
Merged
Conversation
d11nn
requested changes
Aug 4, 2026
d11nn
left a comment
There was a problem hiding this comment.
Hi @carlhus,
Please validate static IPs in PatchSubscriberByID as well
The new validation is applied to POST and PUT, but PATCH /subscriber/:ueId/:servingPlmnId still writes SessionManagementSubscriptionData without calling validateSubscriberStaticIPsForWrite.
carlhus
force-pushed
the
fix/dnn-static-ip
branch
from
August 4, 2026 11:28
1abe982 to
22bcd8b
Compare
Alonza0314
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(webconsole): validate DNN static IP before subscriber writes (#720)
This PR fixes issue #720 in WebConsole subscriber management.
It prevents invalid Static IPv4 addresses from being saved when creating or updating subscribers.
Root cause:
/verify-staticiprequest.Changes:
400for invalid addresses and500for SMF or pool configuration errors.api_verify_test.goto cover pool aggregation and address validation.This is reported in GitHub Issue #720.