refactor: move IntegerField to pydantic #1759
Conversation
|
TODO: if the global idea is ok, move each class from |
pierrecamilleri
left a comment
pierrecamilleri
left a comment
There was a problem hiding this comment.
(apart from 5 console ones not related to modifications)
Were they already failing before ? Even on master branch ?
(normaly CI was passing not so long ago, however I have not investigated CI breaking in #1758 yet)
| ## Field._descriptor properties | ||
| descr = {**descr, **super().to_descriptor(validate=validate)} | ||
| ## Merge descriptor_descr into base_descr to preserve base order | ||
| descr = {**base_descr, **descriptor_descr} |
There was a problem hiding this comment.
If changing the order, the above comment needs to be updated ("_descriptor" has priority)
There was a problem hiding this comment.
As i understand it, it is already the correct way?
There was a problem hiding this comment.
I mean this comment :
Temporarily, Field properties have priority over
Field._descriptor properties
It seems the opposite to me (descriptor_descr overwrites / has priority over base_descr)
BmnQuentin
force-pushed
the
pr-1751-update
branch
from
5d85392 to
feb5a97
Compare
pierrecamilleri
force-pushed
the
refactor/field-no-metadata
branch
from
800f7bf to
e88d66f
Compare
BmnQuentin
force-pushed
the
pr-1751-update
branch
from
276a1b8 to
2a435c8
Compare
2 participants
Integrated pydantic logic to IntegerField.
All tests pass (apart from 5 console ones not related to modifications)
Fixed a few issued: