fix: Include the offending expression in expr2Uci's error message#293
Open
dimension-zero wants to merge 1 commit into
Open
fix: Include the offending expression in expr2Uci's error message#293dimension-zero wants to merge 1 commit into
dimension-zero wants to merge 1 commit into
Conversation
`expr2Uci` raises `invalidArg "expr" "Only union constructors are permitted in expression based queries."` without saying which expression failed. When a caller passes a more complex lambda (e.g. `<@ fun x -> Foo (x + 1) @>`), the user has no signal from the error which call site is the problem. Render the expression via `%A`, cap at 200 chars (long pretty-printed quotations can be unwieldy), and include it in the message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Utils.expr2UciraisesinvalidArg "expr" "Only union constructors are permitted in expression based queries."without naming the expression. Thread the original expression throughsprintf "%A", cap at 200 chars, and include it in the message.Why
Callers using the quoted-DU API (
GetSubCommandParser,GetResult, etc.) can hit this if they pass anything more complex than a bare constructor. Without the expression in the message they have to bisect their call sites to find the offender.Test plan
dotnet build -c Release— cleandotnet test -c Release— 112/112 pass