feat(Nullable): Enable F# nullable reference types on Argu.fsproj#305
Open
dimension-zero wants to merge 1 commit into
Open
feat(Nullable): Enable F# nullable reference types on Argu.fsproj#305dimension-zero wants to merge 1 commit into
dimension-zero wants to merge 1 commit into
Conversation
* Argu.fsproj: <Nullable>enable</Nullable>. * Types.fs: ArguException.ctor inner-exception parameter is now 'Exception | null', accurately reflecting that callers (including the convenience single-arg constructor on line 45) may pass null. The visible signature already accepted null at runtime; this just annotates it. Compile-time hints only. No runtime behaviour change. All 112 tests pass unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(Nullable): Enable F# nullable reference types on Argu.fsproj
'Exception | null', accurately reflecting that callers (including
the convenience single-arg constructor on line 45) may pass null.
The visible signature already accepted null at runtime; this just
annotates it.
Compile-time hints only. No runtime behaviour change. All 112 tests
pass unchanged.