refactor(Cli): Split parseCommandLinePartial into named helpers#309
Open
dimension-zero wants to merge 1 commit into
Open
refactor(Cli): Split parseCommandLinePartial into named helpers#309dimension-zero wants to merge 1 commit into
dimension-zero wants to merge 1 commit into
Conversation
Behaviour-preserving split. The outer match in parseCommandLinePartial now delegates to three named functions: * handleMainCommandOrUnrecognized — the UnrecognizedOrArgument arm, covering main-command primitive/list parsing and the unrecognized-token fallback. * handleGroupedParams — the grouped-switches arm (e.g. '-abc' for '-a -b -c'). * handleCliParam — the dispatch on caseInfo.ParameterInfo for fully parsed CliParam tokens. All four functions are mutually 'and'-bound with parseCommandLineInner so the SubCommand path still recurses cleanly. No call sites change; all 112 tests pass byte-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(Cli): Split parseCommandLinePartial into named helpers
Behaviour-preserving split. The outer match in parseCommandLinePartial
now delegates to three named functions:
covering main-command primitive/list parsing and the
unrecognized-token fallback.
'-a -b -c').
parsed CliParam tokens.
All four functions are mutually 'and'-bound with parseCommandLineInner
so the SubCommand path still recurses cleanly. No call sites change;
all 112 tests pass byte-identical.