perf(PrefixDictionary): Back with a char-keyed trie#316
Open
dimension-zero wants to merge 1 commit into
Open
Conversation
* Utils.fs: New private PrefixTrieNode<'V> with Dictionary<char, ...> children and optional terminal (key, value). PrefixDictionary now builds a trie at construction and does O(L) lookups in TryGetPrefix rather than the previous O(N * L) linear scan over keys. * Public surface preserved exactly: Item, TryGetPrefix, Count, and the IEnumerable<string * 'Value> implementation behave identically. Longest-matching-prefix semantics preserved (the trie tracks the deepest terminal it visits along the way). * Empty-string keys (degenerate but possible) terminate at root and are returned for any input — matching the legacy linear-scan behaviour. All 112 tests pass; this is a small win on schemas with many flags (linear scan replaced with character-walk) and neutral on the small schemas seen in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf(PrefixDictionary): Back with a char-keyed trie
children and optional terminal (key, value). PrefixDictionary now
builds a trie at construction and does O(L) lookups in TryGetPrefix
rather than the previous O(N * L) linear scan over keys.
IEnumerable<string * 'Value> implementation behave identically.
Longest-matching-prefix semantics preserved (the trie tracks the
deepest terminal it visits along the way).
returned for any input — matching the legacy linear-scan behaviour.
All 112 tests pass; this is a small win on schemas with many flags
(linear scan replaced with character-walk) and neutral on the small
schemas seen in tests.