This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Remove cache access from NCM gRPC client#740
Open
DavidLiu506 wants to merge 39 commits intofuturewei-cloud:masterfrom
Open
Remove cache access from NCM gRPC client#740DavidLiu506 wants to merge 39 commits intofuturewei-cloud:masterfrom
DavidLiu506 wants to merge 39 commits intofuturewei-cloud:masterfrom
Conversation
Contributor
Author
|
It works on Jenkins and Medina. |
Contributor
|
@DavidLiu506 Does this PR passes all three neighbor testcases? Scenario#4, Scenario#4.5 and Scenario#5? |
cj-chung
approved these changes
Feb 7, 2022
Contributor
cj-chung
left a comment
cj-chung
left a comment
There was a problem hiding this comment.
LGTM with a minor comment.
Contributor
@DavidLiu506 and @cj-chung I want to double check if we tested the above scenarios e2e. |
Contributor
Author
It tested, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 Remove cache access from NCM gRPC client.
2 In data plane manager, if one port is L2 and L3 neighbor, add L2 and L3 neighbor state to goal state.