Fixed issue where "reference_component_for_position" attribute would not contain the value from the file#61
Open
thiess-cristian wants to merge 2 commits intofva-net:mainfrom
Open
Fixed issue where "reference_component_for_position" attribute would not contain the value from the file#61thiess-cristian wants to merge 2 commits intofva-net:mainfrom
thiess-cristian wants to merge 2 commits intofva-net:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that the ComponentPostProcessor class would change the reference from the file to the internalId of reference. Not sure why this is done since the internalId and reference value can be different, and the model no longer represents the file correctly.
I have added an exception for reference_component_for_position but other reference attributes will have this issue.