Add make_chance_event and remove set_chance_probs - #1012
Open
d-kad wants to merge 6 commits into
Open
Conversation
… terms of make_chance_event
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
make_chance_event#1009Description of the changes in this PR
This PR adds
Game.make_chance_event(nodes, probs[, label])and removesGame.set_chance_probs.MakeChanceEventis implemented in C++ as the parallel ofMakeInfoset(#999). It additionally requiresa probability distribution, given either as a list matching the actions in order or as a possibly-sparse mapping
from action labels to numbers. Nodes need not already be chance nodes; personal decision nodes are converted.
set_chance_probsis removed, subsumed bymake_chance_event.Depends on
GamePlayerRep::CheckInfosetLabel, extracted here fromGameInfosetRep::SetLabelwith no behaviour change; the same commit is on the #999 branch and will drop out on rebase.