Conversation
|
Weird thing I noticed: the |
|
@stertooy Isn't it like DVI file contains timestamp in a comment? |
|
@limakzi It's very likely that a creation date timestamp somewhere in the This doesn't happen in the PDF's because the |
action.yml
Outdated
| if: ${{ inputs.dry-run == 'true' }} | ||
| shell: bash | ||
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}.md | ||
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}${{ inputs.affix }}.md |
There was a problem hiding this comment.
@stertooy Why not?
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}${{ inputs.affix }}.md | |
| run: echo "${{ inputs.body-text }}" > $RUNNER_TEMP/Release_text_for_${PKGNAME}_${VERSION}_${{ inputs.affix }}.md |
There was a problem hiding this comment.
Again, this is because the affix input is expected to be empty, except during the CI tests in this repo. The CI script will put either "-1" or "-2" in the affix input, so an extra underscore isn't needed I think.
fingolfin
left a comment
There was a problem hiding this comment.
Looks good to me, great work!
|
I don't think we should ship the |
Co-authored-by: Max Horn <max@quendi.de>
No longer a problem since gap-actions/build-pkg-docs#42 was merged :) |
As suggested in #50.
The three supported formats,
.tar.gz,.tar.bz2and.zipshould now always be reproducible archives. This is also tested by running this action twice, and then comparing thesha256checksums of both archives.Unfortunately, I had to add an extra input to be able to properly test this. I recommend leaving it undocumented, since it server no purpose for end users.
I've set
SOURCE_DATE_EPOCHto the package release date as specified inPackageInfo.g.