change IsomorphismPermGroupForMatrixGroup#6244
Open
ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
Open
change IsomorphismPermGroupForMatrixGroup#6244ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
IsomorphismPermGroupForMatrixGroup#6244ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
Conversation
Use a known `NiceMonomorphism` also in the case that its image is *not* a permutation group. The idea is: We trust GAP that the image is nicer than the given group, in the sense that computing an `IsomorphismPermGroup` for the image is easier. An example is that the given group is a matrix group in characteristic zero and its `NiceMonomorphism` is a reduction to a matrix group over a finite field. (This strategy works only because `NiceMonomorphism` guarantees an image that is really nicer. Note that other functions do not have this property, for example `SmallerDegreePermutationRepresentation` is allowed to return an identity mapping.)
ThomasBreuer
added
kind: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a known
NiceMonomorphismalso in the case that its image is not a permutation group.The idea is:
We trust GAP that the image is nicer than the given group, in the sense that computing an
IsomorphismPermGroupfor the image is easier.An example is that the given group is a matrix group in characteristic zero and its
NiceMonomorphismis a reduction to a matrix group over a finite field.(This strategy works only because
NiceMonomorphismguarantees an image that is really nicer.Note that other functions do not have this property, for example
SmallerDegreePermutationRepresentationis allowed to return an identity mapping.)(The same change has been implemented in oscar-system/Oscar.jl/pull/5791.)