Fix PreImagesRepresentative for group homomorphisms with OnLines action#6245
Open
ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
Open
Fix PreImagesRepresentative for group homomorphisms with OnLines action#6245ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
PreImagesRepresentative for group homomorphisms with OnLines action#6245ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
Conversation
Arguing with determinants is not enough, one has to ask for the existence of enough scalar matrices.
Contributor
Author
|
(At least) one of the tests gets stuck, due to the newly introduced membership test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #6241
The
PreImagesRepresentativemethod forIsProjectiveActionHomomorphismclaimed to provide enough data in situations where this was in fact not possible:Arguing with determinants is not enough, one has to ask for the existence of enough scalar matrices, see the example in #6241.
I am not sure about a good strategy for checking the correct conditions,
the membership test for a generating scalar matrix is new and is perhaps more expensive than necessary.
On the other hand, the old code computed the kernel of the homomorphism.
Some additional tests might be interesting.
They should mainly check that the changed method returns
fail.