Skip to content

Fix PreImagesRepresentative for group homomorphisms with OnLines action#6245

Open
ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
ThomasBreuer:TB_LinearActionBasis
Open

Fix PreImagesRepresentative for group homomorphisms with OnLines action#6245
ThomasBreuer wants to merge 1 commit intogap-system:masterfrom
ThomasBreuer:TB_LinearActionBasis

Conversation

@ThomasBreuer
Copy link
Contributor

resolves #6241

The PreImagesRepresentative method for IsProjectiveActionHomomorphism claimed to provide enough data in situations where this was in fact not possible:
Arguing with determinants is not enough, one has to ask for the existence of enough scalar matrices, see the example in #6241.

I am not sure about a good strategy for checking the correct conditions,
the membership test for a generating scalar matrix is new and is perhaps more expensive than necessary.
On the other hand, the old code computed the kernel of the homomorphism.

Some additional tests might be interesting.
They should mainly check that the changed method returns fail.

Arguing with determinants is not enough,
one has to ask for the existence of enough scalar matrices.
@ThomasBreuer ThomasBreuer added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Feb 23, 2026
@ThomasBreuer
Copy link
Contributor Author

(At least) one of the tests gets stuck, due to the newly introduced membership test.
This is the test from testbugfix/2016-03-03-t00332.tst which had been added by @hulpke.
Perhaps he can tell me why we are allowed to assume that the old code for LinearActionBasis is correct in this example, such that we can compute preimages under the projective action without NiceMonomorphism overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in PreImagesRepresentative for projective action

1 participant