Skip to content

fix: reject partial browse client env integers#1339

Open
hiSandog wants to merge 1 commit intogarrytan:mainfrom
hiSandog:fix/strict-browse-client-env-20260506
Open

fix: reject partial browse client env integers#1339
hiSandog wants to merge 1 commit intogarrytan:mainfrom
hiSandog:fix/strict-browse-client-env-20260506

Conversation

@hiSandog
Copy link
Copy Markdown
Contributor

@hiSandog hiSandog commented May 6, 2026

Summary

  • require GSTACK_PORT and BROWSE_TAB env values to be full integer strings before accepting them
  • keep the bundled hackernews browser-skill SDK copy in sync with the canonical browse-client
  • add regression coverage for trailing-character env values

Tests

  • /Users/sandog/.real/.bin/bun test browse/test/browse-client.test.ts
  • git diff --check

Note: the first sandboxed test run failed before assertions because Bun.serve(port: 0) could not listen inside the sandbox; the same command passed outside the sandbox.


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant