fix(gemini-adapter): detect new ~/.gemini/oauth_creds.json auth path#1362
Open
abigail-atheryon wants to merge 1 commit intogarrytan:mainfrom
Open
fix(gemini-adapter): detect new ~/.gemini/oauth_creds.json auth path#1362abigail-atheryon wants to merge 1 commit intogarrytan:mainfrom
abigail-atheryon wants to merge 1 commit intogarrytan:mainfrom
Conversation
gemini-cli >=0.30 stores OAuth credentials at ~/.gemini/oauth_creds.json instead of the legacy ~/.config/gemini/ directory. The benchmark adapter's availability check now succeeds for users on recent gemini-cli releases who have authenticated via interactive login. Both paths are accepted so users on older versions still work.
6 tasks
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gemini-cli >=0.30stores OAuth credentials at~/.gemini/oauth_creds.jsoninstead of the legacy~/.config/gemini/directory. The benchmark adapter's availability check still only looks at the legacy path, so users who have authenticated with a recent gemini-cli seeNOT READY — No Gemini auth foundeven though the CLI itself works fine.This patch accepts either path, so older and newer installs both succeed.
Repro before fix
~/.config/gemini/does not exist;~/.gemini/oauth_creds.jsondoes.After fix
Verified end-to-end with a real benchmark run (gpt + gemini, 11.5s, no auth errors).
Test plan
gemini: OKon a host with only~/.gemini/oauth_creds.json~/.config/gemini/path still detected (unchanged code path; trusting OR semantics)🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.