Support load scripts when using PUBLIC_URL env#103
Open
oHaiyang wants to merge 1 commit into
Open
Conversation
oHaiyang
force-pushed
the
support-public-url
branch
from
bc4a07f to
7a7d0a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are deploying our site to a CDN service by using the PUBLIC_URL feature of the create-react-app project. But we got stuck when taking a snapshot, react-snapshot cannot load scripts when they are located under a third-party domain. This pull request interprets the loading process of scripts under PUBLIC_URL domain to load local scripts instead.