Update to base Django 5.2 - #44
Merged
Merged
Conversation
Adds empty tags Backwards compatible in some cases
Addresses getpelican#42
Member
|
Thanks for the submission, Yehuda. I am in transit and just saw this, so I tapped the button to run the CI workflow, and it seems CI is reporting test failure. Would you mind taking a look? |
Contributor
Author
|
@justinmayer Sure, I'll look into it, might be a python <= 3.9 issue |
types.NoneType was added in Python 3.10, it is basically type(None)
Contributor
Author
|
Added a backport for NoneType which was added in Python 3.10, added a test for it and locally tested on all currently supported versions (I also tested 3.13, but that is out of scope for this PR, can open a separate PR for that |
justinmayer
approved these changes
Jul 13, 2025
justinmayer
left a comment
justinmayer
left a comment
Member
There was a problem hiding this comment.
Many thanks for these enhancements, Yehuda! 🌟
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial goal was simply to simply be able to generate a feed that is close enough to the feed I had in Wrodpress, I ended up updating the code to the latest from Django 5.2 (branch stable/5.2.x). Except for
feedgenerator.pyall changed files inutilswere simply overwritten as-is and only the relative imports were fixed.Main changes:
<tag/>instead of<tag></tag>pytzdependency #42)I added some backwards compatibility, while tests pass I might find other changes down the road and will need to update the tests