-
-
Notifications
You must be signed in to change notification settings - Fork 1
Add insight for 16kb page ready #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 80.91% 81.16% +0.25%
==========================================
Files 164 166 +2
Lines 14213 14442 +229
Branches 1501 1516 +15
==========================================
+ Hits 11500 11722 +222
- Misses 2144 2149 +5
- Partials 569 571 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| pass | ||
|
|
||
|
|
||
| class SixteenKBPageReadyInsightResult(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this extend from FilesInsightResult? This way it will integrate more easily into the frontend code.
| continue | ||
|
|
||
| logger.warning( | ||
| f"Android .so unaligned: {relative_path} section '{getattr(section, 'name', 'unknown')}' " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: using a stable log message + extras will make this a bit easier to search
| return False | ||
|
|
||
| except Exception as e: | ||
| logger.error(f"Error analyzing ELF file {relative_path}: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: logger.exception
No description provided.