Update data retention periods - #19049
Open
coolguyzone wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| | Application Metrics | 30 days | 30 days | 30 days | | ||
| | Application Metrics | 30 days | 30 days | 30 days + 13 months sampled | | ||
|
|
||
| **Exception\*:** If you are on a [Team or Business plan](https://sentry.io/settings/billing/overview/) that uses [transaction-based billing](https://docs.sentry.io/pricing/), transactions retention will be 90 days and sampled retention of spans data will not apply. |
Contributor
There was a problem hiding this comment.
Bug: The documentation inconsistently uses an asterisk for an exception on Spans/Transactions but not on Logs or Application Metrics, creating ambiguity about retention policies for transaction-based plans.
Severity: LOW
Suggested Fix
To resolve the ambiguity, either add asterisks to the Logs and Application Metrics rows if the exception applies to them, or update the exception footnote to explicitly clarify whether it applies only to Spans or also to Logs and Application Metrics.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/security-legal-pii/security/data-retention-periods.mdx#L28
Potential issue: The documentation for data retention periods is inconsistent. The table
marks the `Spans/Transactions` row with an asterisk to indicate an exception for
transaction-based billing plans, but fails to do so for the `Logs` and `Application
Metrics` rows, which also now list sampled retention. The exception footnote itself only
mentions "spans data". This creates ambiguity for customers on transaction-based plans,
as they will not know if the exception (which removes sampled retention) also applies to
their logs and application metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES