tests: poll for batch flush instead of fixed sleep#1527
Merged
Conversation
Replace fixed `sleep_ms(20)` with a polling loop (up to 5s) that exits as soon as the flush completes. Fixes flaky `basic_logging_functionality` and `metrics_batch` tests in the CI under CPU pressure where the batcher thread may not get scheduled quickly enough (#1525). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JoshuaMoelans
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fixed
sleep_ms(20)with a polling loop (up to 5s) that exits as soon as the flush completes. Fixes flakybasic_logging_functionalityandmetrics_batchtests on CI under CPU pressure where the batcher thread may not get scheduled quickly enough.Verified locally with
stress+tasksetpinned to a single core (100 iterations, 0 failures).Fixes #1525