Skip to content

feat(sdk): enable 'drop-error-if-contains-third-party-frames' - #121966

Open
JoshuaKGoldberg wants to merge 2 commits into
masterfrom
drop-error-if-contains-third-party-frames
Open

feat(sdk): enable 'drop-error-if-contains-third-party-frames'#121966
JoshuaKGoldberg wants to merge 2 commits into
masterfrom
drop-error-if-contains-third-party-frames

Conversation

@JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 13, 2026

Copy link
Copy Markdown
Member

Like #121862, but using our own product per its docs. 🥇

See: Using thirdPartyErrorFilterIntegration -> 'drop-error-if-contains-third-party-frames'.

Closes DE-1511.

@JoshuaKGoldberg
JoshuaKGoldberg requested review from a team as code owners August 13, 2026 15:41
@JoshuaKGoldberg
JoshuaKGoldberg requested review from chargome, logaretm, msonnb and s1gr1d and removed request for a team August 13, 2026 15:41
@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

DE-1511

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 13, 2026
Comment thread static/app/bootstrap/initializeSdk.tsx
Sentry.thirdPartyErrorFilterIntegration({
filterKeys: ['sentry-spa'],
behaviour: 'apply-tag-if-contains-third-party-frames',
behaviour: 'drop-error-if-contains-third-party-frames',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Changing the Sentry integration to drop-error-if-contains-third-party-frames may cause legitimate first-party errors with mixed stack traces to be silently dropped in production, creating monitoring blind spots.
Severity: MEDIUM

Suggested Fix

Revert the behaviour of thirdPartyErrorFilterIntegration from drop-error-if-contains-third-party-frames back to apply-tag-if-contains-third-party-frames. This will ensure errors with mixed stack traces are still reported and tagged for analysis, preventing the silent loss of potentially important error data. Alternatively, add extensive testing to validate that legitimate errors are not dropped in realistic production scenarios.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: static/app/bootstrap/initializeSdk.tsx#L77

Potential issue: The configuration for `thirdPartyErrorFilterIntegration` was changed
from `apply-tag-if-contains-third-party-frames` to
`drop-error-if-contains-third-party-frames`. This change, active only in production,
will cause any error to be silently dropped if its stack trace contains a single frame
not annotated by the `sentryWebpackPlugin`. While intended to filter third-party noise,
this creates a risk that legitimate first-party errors will be lost if their stack
traces include frames from browser extensions, dynamically loaded scripts, or other
un-annotated sources. This creates a monitoring blind spot, as these errors will
disappear without any record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants