feat(sdk): enable 'drop-error-if-contains-third-party-frames' - #121966
Open
JoshuaKGoldberg wants to merge 2 commits into
Open
feat(sdk): enable 'drop-error-if-contains-third-party-frames'#121966JoshuaKGoldberg wants to merge 2 commits into
JoshuaKGoldberg wants to merge 2 commits into
Conversation
JoshuaKGoldberg
requested review from
chargome,
logaretm,
msonnb and
s1gr1d
and removed request for
a team
August 13, 2026 15:41
ryan953
approved these changes
Aug 13, 2026
chargome
approved these changes
Aug 13, 2026
| Sentry.thirdPartyErrorFilterIntegration({ | ||
| filterKeys: ['sentry-spa'], | ||
| behaviour: 'apply-tag-if-contains-third-party-frames', | ||
| behaviour: 'drop-error-if-contains-third-party-frames', |
Contributor
There was a problem hiding this comment.
Bug: Changing the Sentry integration to drop-error-if-contains-third-party-frames may cause legitimate first-party errors with mixed stack traces to be silently dropped in production, creating monitoring blind spots.
Severity: MEDIUM
Suggested Fix
Revert the behaviour of thirdPartyErrorFilterIntegration from drop-error-if-contains-third-party-frames back to apply-tag-if-contains-third-party-frames. This will ensure errors with mixed stack traces are still reported and tagged for analysis, preventing the silent loss of potentially important error data. Alternatively, add extensive testing to validate that legitimate errors are not dropped in realistic production scenarios.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/app/bootstrap/initializeSdk.tsx#L77
Potential issue: The configuration for `thirdPartyErrorFilterIntegration` was changed
from `apply-tag-if-contains-third-party-frames` to
`drop-error-if-contains-third-party-frames`. This change, active only in production,
will cause any error to be silently dropped if its stack trace contains a single frame
not annotated by the `sentryWebpackPlugin`. While intended to filter third-party noise,
this creates a risk that legitimate first-party errors will be lost if their stack
traces include frames from browser extensions, dynamically loaded scripts, or other
un-annotated sources. This creates a monitoring blind spot, as these errors will
disappear without any record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #121862, but using our own product per its docs. 🥇
See: Using
thirdPartyErrorFilterIntegration->'drop-error-if-contains-third-party-frames'.Closes DE-1511.