chore(ACI): Remove legacy rule creation from project onboarding - #121971
Open
ceorourke wants to merge 3 commits into
Open
chore(ACI): Remove legacy rule creation from project onboarding#121971ceorourke wants to merge 3 commits into
ceorourke wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
ceorourke
commented
Aug 13, 2026
| let ruleId: string | undefined; | ||
| if (alertRuleConfig.shouldCreateCustomRule) { | ||
| const ruleData = await api.requestPromise( | ||
| `/projects/${organization.slug}/${projectData.slug}/rules/`, |
Member
Author
There was a problem hiding this comment.
This endpoint is deprecated and will be deleted soon
ceorourke
marked this pull request as ready for review
August 13, 2026 17:10
Member
Author
|
@getsentry/value-discovery team I noticed you're working on some related stuff so I wanted to make sure you were aware of this - it needs to be removed but if it makes sense to replace it with a workflow, reach out to the issue-workflow team for help if needed. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 18247bf. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
ceorourke
marked this pull request as draft
August 13, 2026 17:27
ceorourke
force-pushed
the
ceorourke/rm-onboarding-rule-creation
branch
from
August 13, 2026 19:51
66d47c3 to
1db2d75
Compare
ceorourke
force-pushed
the
ceorourke/rm-onboarding-rule-creation
branch
from
August 13, 2026 20:09
1db2d75 to
a11f7ac
Compare
ceorourke
marked this pull request as ready for review
August 13, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove legacy rule creation from the onboarding checklist - the endpoint it calls is deprecated and scheduled to be deleted next week. A default workflow is created with a signal on project creation, but we may want to replace this with an onboarding item to create a custom workflow in the future.