ref(hybridcloud): separate out explicit outbox model scheduling - #121993
Open
cvxluo wants to merge 1 commit into
Open
ref(hybridcloud): separate out explicit outbox model scheduling#121993cvxluo wants to merge 1 commit into
cvxluo wants to merge 1 commit into
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
marked this pull request as ready for review
August 13, 2026 20:01
| float(deepest_shard_information[0]["depth"]) if deepest_shard_information else 0.0 | ||
| ) | ||
| metrics.gauge( | ||
| "deliver_from_outbox.maximum_shard_depth", |
Contributor
There was a problem hiding this comment.
Bug: The outbox_name metric tag is now lowercase (e.g., sentry.controloutbox), which is a breaking change from the previous capitalized version, affecting existing monitoring and alerts.
Severity: HIGH
Suggested Fix
To maintain backward compatibility for metrics, ensure the outbox_name tag value remains capitalized. Revert to using the outbox_name variable that was previously used, which is derived from the settings and has the correct casing.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/hybridcloud/tasks/deliver_from_outbox.py#L114
Potential issue: The `outbox_name` tag for metrics was previously derived from
`settings.SENTRY_OUTBOX_MODELS`, resulting in capitalized values like
`"sentry.ControlOutbox"`. The new implementation at this location uses
`outbox_model._meta.label`, which produces lowercase values like
`"sentry.controloutbox"`. This case change is a breaking change for any monitoring,
dashboards, or alerts that filter on the `outbox_name` tag. The change will not raise an
exception but will silently cause existing monitoring queries to fail, breaking
historical continuity and potentially delaying responses to production issues.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just moving this func around to support #121985. For the GAL, we'll want to run separate recovery tasks.