Skip to content

fix(workflows): validate Sentry App action targets #121996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvxluo merged 1 commit into from
Aug 13, 2026
+26 −1
Merged

fix(workflows): validate Sentry App action targets #121996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/notifications/notification_action/action_handler_registry/sentry_app_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SentryAppActionHandler(ActionHandler):
"description": "The configuration schema for a Sentry App Action",
"type": "object",
"properties": {
"target_identifier": {"type": ["string"]},
"target_identifier": {"type": ["string"], "pattern": "^[0-9]+$"},
"target_display": {"type": ["string", "null"]},
"target_type": {
"type": ["integer"],
Expand Down
25 changes: 25 additions & 0 deletions tests/sentry/workflow_engine/endpoints/test_organization_workflow_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,31 @@ def test_update_add_sentry_app_action(self) -> None:
}
assert action.data["settings"] == self.sentry_app_settings

def test_update_rejects_non_numeric_sentry_app_target_identifier(self) -> None:
self.valid_workflow["actionFilters"] = [
{
"logicType": "any",
"conditions": [],
"actions": [
{
"config": {
"targetIdentifier": str(self.sentry_app_installation.uuid),
"targetType": ActionType.SENTRY_APP,
},
"data": {"settings": self.sentry_app_settings},
"type": Action.Type.SENTRY_APP,
},
],
}
]

self.get_error_response(
self.organization.slug,
self.workflow.id,
raw_data=self.valid_workflow,
status_code=400,
)

def test_update_triggers_with_empty_conditions(self) -> None:
"""Test that passing an empty list to triggers.conditions clears all conditions"""
# Create a workflow with a trigger condition
Expand Down
Loading