feat(seerExplorer): Surface residual Explore links and span deep-links - #121997
Conversation
Keep multi-project telemetry bus links visible under call rows, add a get_span_details link rule, and prefer that lib row over its trace child. Co-Authored-By: Dhrumil Parekh <dhrumil.parekh@sentry.io>
github-actions
Bot
added
the
Scope: Frontend
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-retu97o50.sentry.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 47aee09. Configure here.
| return true; | ||
| } | ||
| return Boolean(record.name && PREFER_LIB_OVER_CHILDREN.has(record.name)); | ||
| }); |
There was a problem hiding this comment.
Hidden child hides span lookup failures
Medium Severity
Preferring the get_span_details lib row now drops its HTTP child, but the parent still uses callRecordStatus, which treats a settled lib record with no error or status as success. A 4xx/5xx on the trace request therefore renders as a successful, clickable span row instead of a failed call.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 47aee09. Configure here.
sentry-junior
Bot
added
Trigger: getsentry tests
2 participants
Most of the original request is already shipped on the new
links.tsxtable. This PR closes the remaining gaps.Already done on main
LINK_RULESproject_slugsThis PR
get_span_detailslink rule and prefer that lib row over its less-specific trace child.View spans, etc.).Pair with the seer PR that renames row copy to
Querying {dataset}and emits the span bus link.Test plan
pnpm test-cionlinks.spec.tsx,callRecords.spec.tsx,toolUse.spec.tsx(115 passed)Requested by Dhrumil.
--
View Junior Session [Sentry]