ref(workflow_engine): Remove the TRIGGER_CONDITIONS list - #121998
Open
saponifi3d wants to merge 6 commits into
Open
ref(workflow_engine): Remove the TRIGGER_CONDITIONS list#121998saponifi3d wants to merge 6 commits into
TRIGGER_CONDITIONS list#121998saponifi3d wants to merge 6 commits into
Conversation
…is simplifies it back down to 1
saponifi3d
marked this pull request as ready for review
August 13, 2026 20:36
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 675fbe8. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
saponifi3d
marked this pull request as draft
August 13, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
TRIGGER_CONDITIONSlist, as it's easy to forget to update. We also already have an attribute on a condition,groupthat says if this is a detector trigger, workflow trigger, or action filter -- so this PR refactors the 1 use ofTRIGGER_CONDITIONSto use theDetectorHandler.groupabstraction instead.