Skip to content

Comments

feat: add SOPS_AGE_SSH_PRIVATE_KEY_CMD#2070

Merged
felixfontein merged 1 commit intogetsops:mainfrom
nateschererforks:add-sops-age-ssh-private-key-cmd
Feb 16, 2026
Merged

feat: add SOPS_AGE_SSH_PRIVATE_KEY_CMD#2070
felixfontein merged 1 commit intogetsops:mainfrom
nateschererforks:add-sops-age-ssh-private-key-cmd

Conversation

@natescherer
Copy link
Contributor

Hello! This PR adds support for a new environment variable SOPS_AGE_SSH_PRIVATE_KEY_CMD that functions similarly to SOPS_AGE_KEY_CMD. The value of this variable is executed and the output is used to derive an age key; the idea is for it to be used along with a password manager.

The README was updated with detail on this env var, tests were added that pass, and I also manually built and tested on macOS via make install.

Please let me know if you have any questions or would like anything changed.

Closes #1851.

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

This likely introduces conflicts with #2009 (CC @gokselk), but since that PR is waiting for feedback from more people (and I have no idea how long that will take) I guess there's not much we can do about it here.

@natescherer natescherer force-pushed the add-sops-age-ssh-private-key-cmd branch from e5a0aad to 1114ada Compare February 15, 2026 15:04
@natescherer natescherer force-pushed the add-sops-age-ssh-private-key-cmd branch from a1a9434 to 6ef5014 Compare February 15, 2026 17:55
@natescherer
Copy link
Contributor Author

@felixfontein I think everything should be up-to-date with your requests now. Please let me know if there's anything else you'd like me to change!

@natescherer natescherer force-pushed the add-sops-age-ssh-private-key-cmd branch 3 times, most recently from 68eaf11 to 1f91bb2 Compare February 15, 2026 18:42
@natescherer
Copy link
Contributor Author

Okay, should be up-to-date again (now that I removed the mise and vscode config I accidentally committed, sorry 😬).

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few small improvements. Also I think it would be great to rebase and squash some of the commits (or even all).

Also could you rebase to latest main? Since I cannot push to your branch (and thus can't add a merge commit to change that), I won't be able to merge this unless this PR is based of the latest commit from main.

@natescherer natescherer force-pushed the add-sops-age-ssh-private-key-cmd branch from b956344 to 7e613ba Compare February 15, 2026 20:50
Signed-off-by: Nate Scherer <376408+natescherer@users.noreply.github.com>
@natescherer natescherer force-pushed the add-sops-age-ssh-private-key-cmd branch from d98eb59 to 4569875 Compare February 15, 2026 22:14
@natescherer
Copy link
Contributor Author

natescherer commented Feb 15, 2026

Okay, I completed your latest round of revisions and squashed the whole thing down into a single commit! Should be up-to-date with main now, too.

@felixfontein felixfontein merged commit eb07117 into getsops:main Feb 16, 2026
16 checks passed
@felixfontein
Copy link
Contributor

@natescherer thanks for your contribution!

@natescherer
Copy link
Contributor Author

@natescherer thanks for your contribution!

Thank you for accepting it and for your help improving the code!

@rkast
Copy link

rkast commented Feb 19, 2026

@natescherer nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Add Support for SOPS_AGE_SSH_PRIVATE_KEY_CMD Environment Variable

3 participants