feat: add SOPS_AGE_SSH_PRIVATE_KEY_CMD#2070
Conversation
7067a3c to
d65f4e0
Compare
e5a0aad to
1114ada
Compare
a1a9434 to
6ef5014
Compare
|
@felixfontein I think everything should be up-to-date with your requests now. Please let me know if there's anything else you'd like me to change! |
68eaf11 to
1f91bb2
Compare
|
Okay, should be up-to-date again (now that I removed the mise and vscode config I accidentally committed, sorry 😬). |
felixfontein
left a comment
There was a problem hiding this comment.
Looks good! I have a few small improvements. Also I think it would be great to rebase and squash some of the commits (or even all).
Also could you rebase to latest main? Since I cannot push to your branch (and thus can't add a merge commit to change that), I won't be able to merge this unless this PR is based of the latest commit from main.
b956344 to
7e613ba
Compare
Signed-off-by: Nate Scherer <376408+natescherer@users.noreply.github.com>
d98eb59 to
4569875
Compare
|
Okay, I completed your latest round of revisions and squashed the whole thing down into a single commit! Should be up-to-date with main now, too. |
|
@natescherer thanks for your contribution! |
Thank you for accepting it and for your help improving the code! |
|
@natescherer nice! |
Hello! This PR adds support for a new environment variable
SOPS_AGE_SSH_PRIVATE_KEY_CMDthat functions similarly toSOPS_AGE_KEY_CMD. The value of this variable is executed and the output is used to derive an age key; the idea is for it to be used along with a password manager.The README was updated with detail on this env var, tests were added that pass, and I also manually built and tested on macOS via
make install.Please let me know if you have any questions or would like anything changed.
Closes #1851.