llama-quant : overlap compute and write with double buffering#21507
Open
nuri-yoo wants to merge 1 commit intoggml-org:masterfrom
Open
llama-quant : overlap compute and write with double buffering#21507nuri-yoo wants to merge 1 commit intoggml-org:masterfrom
nuri-yoo wants to merge 1 commit intoggml-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Pipeline the main quantization loop so that the previous tensor's disk write overlaps with the current tensor's compute. Uses a background writer thread and double-buffered work areas.
On macOS (where mmap is disabled) this avoids blocking the main thread on sequential writes. Output is bit-identical to the original.
Benchmark (Qwen3-1.7B Q5_K_M → Q4_0, M4 Pro, macOS):
The improvement should scale with model size since larger tensors have proportionally more I/O to overlap with computation.
Testing
--dry-runmode works correctlytest-quantize-fnspassestest-quantize-perfpassesAdditional information
Closes #20829
Requirements