Java: Restrict results to source literals. - #20054
Merged
aschackmull merged 1 commit intoJul 15, 2025
Merged
Conversation
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restricts a CodeQL query to only analyze source literals rather than compiled bytecode literals. The change addresses performance issues caused by literals extracted from .class files that contain many control characters, which can cause the query to become inefficient while providing limited value.
- Adds a filter to restrict analysis to source compilation units only
- Adds documentation explaining why Kotlin files are excluded to prevent false positives
owen-mc
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some literals extracted from
.classfiles can contain many control chars, which can cause this query to blow up. Those results are pretty useless, so we can simply exclude them.