C#: Support replaces-base via the DependabotProxy. - #22494
Draft
michaelnebel wants to merge 8 commits into
Draft
Conversation
michaelnebel
force-pushed
the
csharp/replaces-base
branch
4 times, most recently
from
September 3, 2026 13:58
e4e0207 to
9d030bd
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Feed-check opt-out behavior is regressed, and one fallback path can still retain nuget.org.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This now probes the default feeds even when `CODEQL_EXTRACTOR_CSHARP_BUILDLESS_NUGET_FEEDS_CHECK=fal… |
What changed in this PR
Adds replaces-base support for private NuGet registries used during buildless C# dependency restoration.
Changes:
- Parses and exposes replacement-base registry URLs.
- Uses replacement registries for default and fallback feeds.
- Adds unit coverage and a change note.
| File | Description |
|---|---|
csharp/ql/lib/change-notes/2026-09-03-replaces-base.md |
Documents the new behavior. |
csharp/extractor/Semmle.Extraction.Tests/FeedManager.cs |
Tests default and fallback feed selection. |
csharp/extractor/Semmle.Extraction.Tests/DependabotProxy.cs |
Tests replaces-base parsing. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/PackagesConfigRestorer.cs |
Uses reachable default feeds during restoration. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/IDependabotProxy.cs |
Exposes replacement-base registry URLs. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs |
Selects replacement registries as default feeds. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependabotProxy.cs |
Parses and stores registry replacement metadata. |
Suppressed comments (1)
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs:315
- The replacement is only applied through
GetReachableFallbackNugetFeeds, butNugetPackageRestorer.DownloadMissingPackagescalls that path only when feed responsiveness checks are enabled; its disabled branch usesAllFeeds, which can still contain inheritednuget.org. Thusreplaces-base: truedoes not actually replace the public base feed in fallback downloads when the supported responsiveness opt-out is used. Please separate construction of the configured fallback set from reachability filtering and use that set in both branches.
fallbackFeeds.UnionWith(defaultFeeds);
logger.LogInfo($"No fallback NuGet feeds specified. Adding default feeds: {string.Join(", ", defaultFeeds.OrderBy(f => f))}");
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…Ls to replace the default NuGet feed.
michaelnebel
force-pushed
the
csharp/replaces-base
branch
from
September 4, 2026 09:09
9d030bd to
4e3476f
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The responsiveness-check opt-out path can still use public NuGet.org despite a configured replacement registry.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — DefaultFeeds is substituted only on the responsiveness-checking path. When… |
Pre-existing issues (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This now probes the default feeds even when `CODEQL_EXTRACTOR_CSHARP_BUILDLESS_NUGET_FEEDS_CHECK=fal… View comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Public NuGet endpoint variants such as the supported v2 URL are not replaced.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This only recognizes the canonical v3 URL, so a configured public NuGet source such as… |
Pre-existing issues (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — DefaultFeeds is substituted only on the responsiveness-checking path. When… View comment |
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This now probes the default feeds even when `CODEQL_EXTRACTOR_CSHARP_BUILDLESS_NUGET_FEEDS_CHECK=fal… View resolved comment |
michaelnebel
force-pushed
the
csharp/replaces-base
branch
from
September 4, 2026 12:44
d34b10b to
20e2e56
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The release note inaccurately describes the replacement behavior as fallback-only.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
csharp/ql/lib/change-notes/2026-09-03-replaces-base.md — The release note describes the replacement as fallback-only, but GetFeeds now replaces NuGet.org… |
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This only recognizes the canonical v3 URL, so a configured public NuGet source such as… View resolved comment |
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — DefaultFeeds is substituted only on the responsiveness-checking path. When… View resolved comment |
michaelnebel
force-pushed
the
csharp/replaces-base
branch
from
September 4, 2026 12:58
20e2e56 to
e4b277b
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation is coherent and the remaining documentation and regression-test gaps are minor.
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.Tests/FeedManager.cs — The replacement test still supplies the canonical v3 endpoint in both inputs, so the newly… |
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This makes the fallback default conditional on replaces-base, but the public XML documentation… |
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
csharp/ql/lib/change-notes/2026-09-03-replaces-base.md — The release note describes the replacement as fallback-only, but GetFeeds now replaces NuGet.org… View resolved comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A trailing semicolon after the nested class declaration causes a compilation error.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
Pre-existing issues (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs — This makes the fallback default conditional on replaces-base, but the public XML documentation… View comment |
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
csharp/extractor/Semmle.Extraction.Tests/FeedManager.cs — The replacement test still supplies the canonical v3 endpoint in both inputs, so the newly… View resolved comment |
…s replaces-base is set, otherwise use nuget.org.
… private registries with replaces-base: true is set.
…vate registries are configured (to make implementation consistent).
michaelnebel
force-pushed
the
csharp/replaces-base
branch
from
September 4, 2026 13:15
7b5b63e to
983dbbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add support using the
replace-baseflag for private registries. If any private registries are configured to replace base, then we use these registries as NuGet feed sources instead of the default publicnuget.orginfallback scenariosall scenarios - even if the public NuGet feed is mentioned innuget.configfiles (unless it is explicitly configured as a fallback feed as well).As an add on for this PR, we also prevent the fallback that doesn't provide feeds via the command line when restoring packages manually, if private registries are configured (to make the logic consistent with other similar paths).
DCA looks good.