Skip to content

test: fix config writer tests on macOS #7608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Aug 21, 2026
+13 −3
Merged

test: fix config writer tests on macOS #7608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/config-writer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,13 @@ describe('writeConfigs', () => {
process.env.GITHUB_WORKSPACE = workspaceDir;
fs.mkdirSync(workspaceDir, { recursive: true });
fs.chmodSync(workspaceDir, 0o777);
const canonicalWorkspaceDir = fs.realpathSync(workspaceDir);

await writeConfigs(buildWriteConfig(tempDir, { containerWorkDir: workspaceDir }));

expect(execa.sync).toHaveBeenCalledWith(
'chown',
['-h', '-P', '-R', '--', '1000:1000', workspaceDir],
['-h', '-P', '-R', '--', '1000:1000', canonicalWorkspaceDir],
expect.objectContaining({ reject: false })
);
});
Expand All @@ -162,12 +163,13 @@ describe('writeConfigs', () => {
process.env.GITHUB_WORKSPACE = workspaceDir;
fs.mkdirSync(containerWorkDir, { recursive: true });
fs.chmodSync(workspaceDir, 0o777);
const canonicalWorkspaceDir = fs.realpathSync(workspaceDir);

await writeConfigs(buildWriteConfig(tempDir, { containerWorkDir }));

expect(execa.sync).toHaveBeenCalledWith(
'chown',
['-h', '-P', '-R', '--', '1000:1000', workspaceDir],
['-h', '-P', '-R', '--', '1000:1000', canonicalWorkspaceDir],
expect.objectContaining({ reject: false })
);
});
Expand All @@ -179,11 +181,19 @@ describe('writeConfigs', () => {
process.env.GITHUB_WORKSPACE = workspaceDir;
fs.mkdirSync(workspaceDir, { recursive: true });
fs.chmodSync(workspaceDir, 0o755);
const canonicalWorkspaceDir = fs.realpathSync(workspaceDir);
const actualStatSync = jest.requireActual<typeof import('fs')>('fs').statSync;
(fs.statSync as jest.Mock).mockImplementation((targetPath: fs.PathLike) => {
const stat = actualStatSync(targetPath);
return String(targetPath) === canonicalWorkspaceDir
? Object.assign(stat, { uid: 0, gid: 0 })
: stat;
});

await expect(
writeConfigs(buildWriteConfig(tempDir, { containerWorkDir: workspaceDir }))
).rejects.toThrow(
`Host workspace is not writable by the sandbox identity (1000:1000): ${workspaceDir}`
`Host workspace is not writable by the sandbox identity (1000:1000): ${canonicalWorkspaceDir}`
);
});

Expand Down
Loading