Add MariaDB support for --move-tables mode - #1756
Open
ericyan wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MariaDB compatibility and CI coverage for move-tables migrations.
Changes:
- Adds MariaDB images and replication setup.
- Uses MariaDB-specific GTID coordinates during cutover and resume.
- Makes fixtures and metadata-lock checks compatible with MariaDB.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/move-tables-tests.yml |
Expands the database test matrix. |
script/docker-gh-ost-move-tables-tests |
Configures MySQL/MariaDB containers and replication. |
localtests/docker-compose-move-tables.yml |
Accepts engine-specific server options. |
localtests/move-tables-test.sh |
Handles MariaDB GTID verification. |
localtests/move-tables/generated-columns/create.sql |
Makes generated columns portable. |
go/logic/migrator.go |
Selects the correct drain GTID variable and skips irrelevant metadata-lock checks. |
go/logic/applier.go |
Restores the source GTID flavor when resuming. |
go/logic/migrator_move_tables_cutover_test.go |
Tests GTID variable selection. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced
--move-tables mode
jakubpliszka
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds MariaDB coverage and compatibility support for
--move-tablesmode:RENAME TABLEfollowed by a drain to the captured GTID; it never invokesatomicCutOver(),AtomicCutOverMagicLock, orExpectMetadataLock.script/cibuildreturns with no formatting errors, build errors or unit test errors.