[dashboard-language] Built-in pages: runs run-link coverage validation - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone
Built-in pages
Specification coverage
This increment covers Section 10 built-in page validation for:
DLS-PAGE-006— conservativerunsbuilt-in run-link coverage validationDLS-PAGE-014— carried through the existing implementation-local built-in data-state exposure contract for the same sliceWhat shipped
pages/dashboard/src/specification.jsso the implementation-local declarative definition for therunsbuilt-in page now requires bothrunsandoutcomessource coverage.run-linkvia anoutcomesview for therunsbuilt-in page.pages/dashboard/test/unit/validator.test.jswith:DLS-PAGE-006fixture for missing declarativeoutcomescoverageDLS-PAGE-006fixture for missingrun-linkexposureoutcomesview exposingrun-linkpages/dashboard/PLAN.mdto mark the slice complete, record the run, and note the next built-in validation slice.Gates
From
pages/dashboard/:npm install✅npm run typecheck./node_modules/.bin/tsc -p tsconfig.json --noEmit✅npm run lint./node_modules/.bin/eslint .✅npm test./node_modules/.bin/vitest run --environment jsdom✅npm run test:e2ebrowserType.launch: Executable doesn't exist)Blockers
node_modules/.binwere used to verify those gates successfully.Next milestone
Built-in pages — conservative validation of
overviewfindings-link and operational-value timeline coverage without inventing presenter semantics.