Skip to content

Fix dashboard E2E locator assertions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 29, 2026
Merged

Fix dashboard E2E locator assertions #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04dc018
Initial plan
Copilot Aug 29, 2026
f140596
Fix dashboard E2E selectors
Copilot Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pages/dashboard/test/e2e/smoke.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,15 @@ test('DLS-PAGE-006 DLS-PAGE-014 built-in runs page renders status counts, outcom
`);

await expect(page.getByRole('heading', { name: 'Built In Runs Render' })).toBeVisible();
await expect(page.getByRole('heading', { name: 'Runs', exact: true })).toBeVisible();
await expect(page.getByRole('heading', { name: 'Runs', exact: true, level: 2 })).toBeVisible();
await expect(page.locator('[data-state-axis="availability"]')).toHaveText('available');
await expect(page.locator('[data-state-axis="completeness"]')).toHaveText('partial');
await expect(page.locator('[data-state-axis="freshness"]')).toHaveText('stale');
await expect(page.locator('.run-status-counts')).toContainText(['completed: 1', 'in-progress: 1']);
await expect(page.locator('.run-conclusion-counts')).toContainText(['success: 1', 'unknown: 1']);
await expect(page.locator('.run-outcome-counts')).toContainText(['accepted: 1', 'pending: 1']);
await expect(page.locator('.run-status-counts li')).toContainText(['completed: 1', 'in-progress: 1']);
await expect(page.locator('.run-conclusion-counts li')).toContainText(['success: 1', 'unknown: 1']);
await expect(page.locator('.run-outcome-counts li')).toContainText(['accepted: 1', 'pending: 1']);
await expect(page.locator('tbody tr')).toHaveCount(2);
await expect(page.locator('tbody tr').first()).toContainText([
await expect(page.locator('tbody tr').first().locator('td')).toContainText([
'1001',
'completed',
'success',
Expand All @@ -147,7 +147,7 @@ test('DLS-PAGE-006 DLS-PAGE-014 built-in runs page renders status counts, outcom
'2',
'Run 1001'
]);
await expect(page.locator('tbody tr').nth(1)).toContainText([
await expect(page.locator('tbody tr').nth(1).locator('td')).toContainText([
'1002',
'in-progress',
'unknown',
Expand Down