[rig-claude] Improve Claude dynamic-workflow compatibility for rig - #514
Merged
Merged
Conversation
Promise.all bypasses the shared concurrency limiter, which breaks the Claude dynamic-workflow porting contract. Update the primitive mapping to make the cast approach primary and warn against Promise.all in workflow bodies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — approving with one minor suggestion.
📋 Findings
Positive Highlights
- ✅ Fix is correct:
Promise.allgenuinely bypasses the concurrency limiter and thenull-hole failure model — the warning is well-motivated. - ✅ The cast approach is the right recommendation; the reordering makes the safe path obvious.
- ✅ Consistent with the existing table note on
360-parallel-branch-analysis-workflow.md("use instead ofPromise.allwhen porting").
One suggestion (non-blocking)
The Behavior differences section does not yet mention the Promise.all pitfall. A porter who jumps straight to that section could still miss the warning. See inline comment for a suggested bullet.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 25.5 AIC · ⌖ 6.97 AIC · ⊞ 6.3K
Comment /matt to run again
| | `await agent(prompt, { schema })` | `await call.json(prompt, schema, options?)` | `schema` is any `s.*` value (`s.object`, `s.enum`, `s.array`, …); result is typed and validated. Claude workflows only support object schemas; rig accepts any schema type. | | ||
| | Reused prompt + schema pair | `agent({ input, output, instructions })` then `call(worker, input, options?)` | Preferred for anything invoked more than once | | ||
| | `parallel(thunks)` | `parallel(thunks)` | Same barrier semantics; failures become `null` holes. **TypeScript note:** `parallel` uses a single generic `Result` type, so all thunks must return the same type. For agents with different output types, use `Promise.all` (which skips the concurrency limiter) or cast: `parallel<TypeA \| TypeB>([...]) as Promise<[TypeA \| null, TypeB \| null]>`. | | ||
| | `parallel(thunks)` | `parallel(thunks)` | Same barrier semantics; failures become `null` holes. **TypeScript note:** `parallel` uses a single generic `Result` type, so all thunks must return the same type. For agents with different output types, cast to preserve limiter semantics: `parallel<TypeA \| TypeB>([...]) as Promise<[TypeA \| null, TypeB \| null]>`. Avoid `Promise.all` in workflow bodies — it bypasses the concurrency limiter and skips the `null`-hole failure model that `parallel` provides. | |
Contributor
Author
There was a problem hiding this comment.
[/grill-with-docs] The updated parallel row now warns against Promise.all, but the Behavior differences section — the place porters check before finalising a migration — does not mention this pitfall. A developer skimming that section could still reach for Promise.all for heterogeneous types.
💡 Suggested addition to "Behavior differences"
- **Avoid `Promise.all` in workflow bodies.** `Promise.all` bypasses the shared concurrency limiter and propagates exceptions instead of producing `null` holes. Use `parallel(thunks)` (casting for heterogeneous output types) to match Claude dynamic-workflow semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility gap addressed
The
parallelprimitive mapping inskills/rig/references/claude-workflow-conversion.mdpreviously recommendedPromise.allas the fallback for heterogeneous agent output types. This is misleading:Promise.allbypasses the shared concurrency limiter and skips thenull-hole failure model thatparallelprovides — both of which are semantically important when porting from Claude dynamic workflows.Why this improves transfer from Claude dynamic workflows to rig
Claude dynamic workflows'
parallel(thunks)always runs inside the limiter. A developer who ports to rig and follows the old guidance (use Promise.all) gets silently different behavior: unlimited concurrency and exceptions propagating instead ofnullholes. The fix makes the cast approach the recommended path and adds an explicit warning aboutPromise.all.Files changed
skills/rig/references/claude-workflow-conversion.md— updated theparallel(thunks)row in the primitive mapping tableValidation
Docs-only change; no code was modified. No additional validation beyond reviewing the edited file for broken links (none found).
Remaining intentional differences
All existing intentional differences documented in the file are preserved. No new differences introduced.