Skip to content

fix(secret): don't apply unset fields#630

Merged
wass3rw3rk merged 3 commits intomainfrom
fix/secret-update
Mar 5, 2026
Merged

fix(secret): don't apply unset fields#630
wass3rw3rk merged 3 commits intomainfrom
fix/secret-update

Conversation

@wass3r
Copy link
Copy Markdown
Collaborator

@wass3r wass3r commented Feb 27, 2026

fixes go-vela/community#1058

applies to images/repo lists

images, repo sets should not be sent if not supplied
@wass3r wass3r requested a review from a team as a code owner February 27, 2026 20:12
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.33%. Comparing base (15bda2c) to head (3cb3709).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
command/secret/update.go 66.66% 4 Missing and 2 partials ⚠️
action/secret/update.go 71.42% 1 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (71.33%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   71.44%   71.33%   -0.12%     
==========================================
  Files         174      174              
  Lines        4718     4727       +9     
==========================================
+ Hits         3371     3372       +1     
- Misses       1042     1047       +5     
- Partials      305      308       +3     
Files with missing lines Coverage Δ
action/secret/secret.go 80.00% <ø> (ø)
action/secret/update.go 76.25% <71.42%> (-1.09%) ⬇️
command/secret/update.go 73.68% <66.66%> (-14.56%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wass3rw3rk wass3rw3rk merged commit 1f6d785 into main Mar 5, 2026
14 of 17 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/secret-update branch March 5, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] Updating a secret value should not reset image/repo allowlist

4 participants