Fix renaming bug triggered by static locals hiding other locals/formals.#229
Open
difcsi wants to merge 1 commit into
Open
Fix renaming bug triggered by static locals hiding other locals/formals.#229difcsi wants to merge 1 commit into
difcsi wants to merge 1 commit into
Conversation
When a static local is promoted to a global, the alpha renaming usually remembers any suffix added and chooses a fresh suffix for later vars of the same name. However, if the same function also has a (non-static) local with the same name, this gets clobbered: the alpha renamer throws away the renaming state after the function scope is done. This can be triggered if (among other cases) two functions in the same file both have like-named statics hiding other locals/formals (seen in Motif). Co-authored-by: Stephen Kell <srk31@srcf.ucam.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I'm Zoltán, working with Stephen (#228) on some CIL-related things. Besides the architectural changes, we have some bug fixes that we are keen to contribute to your efforts.
When a static local is promoted to a global, the alpha renaming usually remembers any suffix added and chooses a fresh suffix for later vars of the same name. However, if the same function also has a (non-static) local with the same name, this gets clobbered: the alpha renamer throws away the renaming state after the function scope is done. This can be triggered if (among other cases) two functions in the same file both have like-named statics hiding other locals/formals (seen in Motif).