Skip to content

chore: test email does not change #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prolific117 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

chore: test email does not change #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc9a3b1
chore: test email does not change
prolific117 Mar 15, 2023
e0ef11e
chore: fixed test
prolific117 Mar 15, 2023
2729298
chore: fixed test
prolific117 Mar 15, 2023
598c19f
chore: fixed test
prolific117 Mar 15, 2023
6be4b1d
chore: fixed test
prolific117 Mar 15, 2023
71c18b6
Merge branch 'master' into test-email
martin-nef Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Test
run: |-
export TERM=${TERM:-dumb}
./gradlew test
./gradlew test --debug
# test build
- name: Build with Gradle
run: ./gradlew build
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/com/gocardless/GoCardlessClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public void shouldCreateACustomer() throws Exception {
http.enqueueResponse(201, "fixtures/client/create_a_customer_response.json");
Customer customer = client.customers().create().withHeader("Accept-Language", "fr-FR")
.withFamilyName("Osborne").withGivenName("Sharon").withAddressLine1("27 Acer Road")
.withAddressLine2("Apt 2").withCity("London").withPostalCode("E8 3GX")
.withAddressLine2("Apt 2").withCity("London").withPostalCode("E8 3GX").withEmail("[email protected]")
.withCountryCode("GB").execute();
assertThat(customer.getId()).isNotNull();
assertThat(customer.getFamilyName()).isEqualTo("Osborne");
Expand All @@ -122,7 +122,7 @@ public void shouldCreateACustomer() throws Exception {
public void shouldCreateACustomerWithAGeneratedIdempotencyKey() throws Exception {
http.enqueueResponse(201, "fixtures/client/create_a_customer_response.json");
CustomerCreateRequest request = client.customers().create()
.withHeader("Accept-Language", "fr-FR").withFamilyName("Osborne")
.withHeader("Accept-Language", "fr-FR").withFamilyName("Osborne").withEmail("[email protected]")
.withGivenName("Sharon").withAddressLine1("27 Acer Road").withAddressLine2("Apt 2")
.withCity("London").withPostalCode("E8 3GX").withCountryCode("GB");
request.execute();
Expand All @@ -139,7 +139,7 @@ public void shouldHandleConflictWhenCreatingACustomer() throws Exception {
http.enqueueResponse(409, "fixtures/conflict.json");
http.enqueueResponse(200, "fixtures/client/create_a_customer_response.json");
CustomerCreateRequest request = client.customers().create()
.withHeader("Accept-Language", "fr-FR").withFamilyName("Osborne")
.withHeader("Accept-Language", "fr-FR").withFamilyName("Osborne").withEmail("[email protected]")
.withGivenName("Sharon").withAddressLine1("27 Acer Road").withAddressLine2("Apt 2")
.withCity("London").withPostalCode("E8 3GX").withCountryCode("GB");
request.execute();
Expand Down
1 change: 1 addition & 0 deletions src/test/resources/fixtures/client/create_a_customer_request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"address_line2": "Apt 2",
"city": "London",
"country_code": "GB",
"email": "[email protected]",
"family_name": "Osborne",
"given_name": "Sharon",
"postal_code": "E8 3GX"
Expand Down