Skip to content

Conversation

@heathdutton
Copy link

@heathdutton heathdutton commented Dec 16, 2025

Previously, if there was an import cycle in the packages being built
(e.g., package A imports B and B imports A), the build would deadlock
with "all goroutines are asleep - deadlock!" because each package's
goroutine would block waiting for the other to complete.

Now we detect import cycles before blocking on each dependency by
tracking an "install stack" of which package is waiting on which.
Before waiting for a dependency, we walk the stack to check if that
dependency is already waiting on us. When a cycle is detected, we
report it with a clear message like "import cycle: A -> B -> A".

Tested:

  • Self-import cycle detection (go/ast imports go/ast)
  • Indirect import cycle detection (go/token imports go/ast creates
    cycle through go/ast -> go/token -> go/ast)
  • Normal builds complete successfully
  • all.bash passes

Fixes #76439

@google-cla
Copy link

google-cla bot commented Dec 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: a4e4a2a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/730620.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/730620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/730620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/730620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Funda Secgin:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/730620.
After addressing review feedback, remember to publish your drafts!

Previously, if there was an import cycle in the packages being built
(e.g., package A imports B and B imports A), the build would deadlock
with "all goroutines are asleep - deadlock!" because each package's
goroutine would block waiting for the other to complete.

Now we detect import cycles before blocking on each dependency by
tracking an "install stack" of which package is waiting on which.
Before waiting for a dependency, we walk the stack to check if that
dependency is already waiting on us. When a cycle is detected, we
report it with a clear message like "import cycle: A -> B -> A".

Fixes golang#76439
@heathdutton heathdutton force-pushed the fix-76439-dist-import-cycle-deadlock branch from a4e4a2a to 6fd66c7 Compare December 23, 2025 05:21
@gopherbot
Copy link
Contributor

This PR (HEAD: 6fd66c7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/730620.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd/dist: import cycle causes deadlock

2 participants