feat: improve Lit client robustness for message handling#419
feat: improve Lit client robustness for message handling#419doitundoit wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add fallback mechanism to retrieve agent messages from history when status.message.parts is empty - Handle string-encoded JSON data parts by parsing them - Add debug logging (console.debug) for better traceability
730b139 to
9560b98
Compare
paullewis
left a comment
There was a problem hiding this comment.
Nit: might be worth adding a bit of an explanation to this but approving all the same.
Hi, thanks for the feedback! I've added concise comments explaining the rationale behind the history fallback and JSON parsing logic for better clarity. |
|
Thanks for improving the Lit shell client robustness, @doitundoit! The history-based fallback for session resumption is a good idea. 🙏 The Lit shell client has been significantly updated since this PR was opened, and the A2A SDK response format has evolved as well. This PR would need a substantial rebase against the current codebase. Closing as stale — but the insight about handling empty status parts via history fallback is worth filing as a focused issue if you find it's still needed! |
Summary
This PR improves the Lit client's robustness when handling agent response messages.
Changes
status.message.partsis emptyconsole.debugstatements for better traceability during developmentAffected file:
samples/client/lit/shell/client.tsVerification
npm run build:tsc)Related
Split from #396 as requested by reviewer to keep commit scope narrow and targeted.