Skip to content

feat: improve Lit client robustness for message handling#419

Closed
doitundoit wants to merge 2 commits intogoogle:mainfrom
doitundoit:feat/lit-client-robustness
Closed

feat: improve Lit client robustness for message handling#419
doitundoit wants to merge 2 commits intogoogle:mainfrom
doitundoit:feat/lit-client-robustness

Conversation

@doitundoit
Copy link
Copy Markdown
Contributor

Summary

This PR improves the Lit client's robustness when handling agent response messages.

Changes

  • History fallback: Added fallback mechanism to retrieve agent messages from history when status.message.parts is empty
  • String-encoded JSON handling: Parse string-encoded JSON data parts that some agents may return
  • Debug logging: Added console.debug statements for better traceability during development

Affected file:

  • samples/client/lit/shell/client.ts

Verification

  • TypeScript build passes (npm run build:tsc)

Related

Split from #396 as requested by reviewer to keep commit scope narrow and targeted.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jan 3, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

- Add fallback mechanism to retrieve agent messages from history when status.message.parts is empty
- Handle string-encoded JSON data parts by parsing them
- Add debug logging (console.debug) for better traceability
@doitundoit doitundoit force-pushed the feat/lit-client-robustness branch from 730b139 to 9560b98 Compare January 3, 2026 05:18
Copy link
Copy Markdown
Collaborator

@paullewis paullewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: might be worth adding a bit of an explanation to this but approving all the same.

@doitundoit
Copy link
Copy Markdown
Contributor Author

Nit: might be worth adding a bit of an explanation to this but approving all the same.

Hi, thanks for the feedback! I've added concise comments explaining the rationale behind the history fallback and JSON parsing logic for better clarity.

@zeroasterisk
Copy link
Copy Markdown
Collaborator

Thanks for improving the Lit shell client robustness, @doitundoit! The history-based fallback for session resumption is a good idea. 🙏

The Lit shell client has been significantly updated since this PR was opened, and the A2A SDK response format has evolved as well. This PR would need a substantial rebase against the current codebase. Closing as stale — but the insight about handling empty status parts via history fallback is worth filing as a focused issue if you find it's still needed!

@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants