feat: Add map image support to Rizzcharts with local placeholder #420
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add local map-placeholder.png to shell public directory - Update standard_catalog/map.json with map-image component using local image - Update agent.py to instruct LLM to use local placeholder (or Google Maps API if key available) - Avoids dependency on external placehold.co service
doitundoit
force-pushed
the
feat/rizzcharts-map-support
branch
from
3a51069 to
a1839f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds map image support to the Rizzcharts sample agent, using a local placeholder image instead of relying on external services.
Changes
map-placeholder.pngtosamples/client/lit/shell/public/map-imagecomponent using local/map-placeholder.pngpathGOOGLEMAPS_API_KEYenv var is setAffected files:
samples/client/lit/shell/public/map-placeholder.png[NEW]samples/agent/adk/rizzcharts/examples/standard_catalog/map.jsonsamples/agent/adk/rizzcharts/agent.pyVerification
Related
Addresses feedback from #396 - reviewer requested avoiding external placeholder services like placehold.co.